fix: Stylable variables exports type and generated dts and sourcemaps files
#2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzachbon
changed the title
dts and sourcemaps filesdts and sourcemaps files
tzachbon
changed the title
dts and sourcemaps filesdts and sourcemaps files
tomrav
approved these changes
Jan 16, 2022
| @@ -280,3 +322,20 @@ export function generateDTSSourceMap(dtsContent: string, meta: StylableMeta) { | |||
| 4 | |||
| ); | |||
| } | |||
|
|
|||
| function calculateEstimatedPosition( | |||
There was a problem hiding this comment.
maybe open an issue (or comment on the value parser issue) about this as a tech debt
|
The new types that are part of the public api should be exported as well |
tzachbon
added a commit
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2249, closes #2250
Currently, there will be types duplication in the
coreand in theruntimepackages.There should be a decision if core should be dependent on the runtime or vise-versa, or there should be a dedicated
runtime-typespackage. (#2257)