Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): downgrade csso #2221

Closed
wants to merge 1 commit into from
Closed

Conversation

barak007
Copy link
Collaborator

@barak007 barak007 commented Dec 22, 2021

So it turns out csso@5 which uses css-tree@2 is kind of broken for our case that uses the tpa-processor. it removes whitespace where it (maybe) should not.

I also opened issue in csso repo:
css/csso#447

We might not want to merge this and solve it from outside

@barak007 barak007 requested a review from AviVahl December 22, 2021 15:02
@barak007
Copy link
Collaborator Author

So after thinking about this issue a little more I think that we should not downgrade and instead allow our integrations to accept minifier from outside at first stage and remove the built-in minifier next major

@barak007 barak007 changed the title fix(optimizer): downgrade broken csso fix(optimizer): downgrade csso Dec 22, 2021
@barak007
Copy link
Collaborator Author

So it turns out we have a way to override the minify function from the outside so no work should be done here.

@barak007 barak007 closed this Dec 23, 2021
@barak007 barak007 deleted the barak/fix-broken-csso branch January 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant