feat: deploy libraries and proxy contract as singletons #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocao
reviewed
May 13, 2021
mariocao
reviewed
May 13, 2021
mariocao
reviewed
May 13, 2021
aesedepece
reviewed
May 13, 2021
mariocao
reviewed
May 13, 2021
mariocao
suggested changes
May 17, 2021
mariocao
reviewed
May 17, 2021
mariocao
reviewed
May 18, 2021
aesedepece
requested changes
May 18, 2021
|
Once the PR #165 is merged, |
|
The PR is now merged, so after a rebase you will found "some" new warnings 😄 |
mariocao
reviewed
May 18, 2021
mariocao
reviewed
May 18, 2021
Tommytrg
reviewed
May 18, 2021
All warnings/errors solved on latest commit: 8c2cbdc |
Co-authored-by: Claudia Bartoli Duncan <[email protected]>
mariocao
force-pushed
the
master
branch
2 times, most recently
from
2230f68 to
f45186b
Compare
|
Supeseded by #317. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingletonFactorycontractWitnetRequestBoardProxycontractMigrationsandSingletonFactoryinto subfolderssingletons.jsonconfiguration file*singleton*.jsscripts for deploying as singletons the libraries and contracts referred onsingletons.jsonaddresses.jsonfile, and recreate file template if not foundWitnetRequestBoardis not to become singletonaddresses.jsonif any change on singleton addresses is produced (i.e. contract codehash changed)Closes #162