Add support for networks using WitnetFeeds contract #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
commented
Jan 19, 2024
Tommytrg
force-pushed
the
feat/price-feed-router
branch
9 times, most recently
from
cdfcc17 to
011d4a9
Compare
Tommytrg
force-pushed
the
feat/price-feed-router
branch
2 times, most recently
from
be286ee to
bfc2264
Compare
Tommytrg
changed the title
Add support for networks using [WitnetFeeds contract](https://github.com/witnet/witnet-solidity-bridge/blob/2.0.x/contracts/apps/WitnetFeeds.sol): - Implement the NetworkRouter class that handles all the communication with each network. - Listen to the networks using the `WitnetPriceRouter` with `listenLegacyPriceRouter` and the new network using `WitnetFeeds` with `listenWitnetPriceFeeds`. - Update the configuration file. The networks still using the old witnet price router are marked using `legacy: true` in the network configuration. Also, the file configuration has been updated to include the feed key. This new key consists of a map with the default values of the existing price feeds. According to that, the price feeds deployed using the default configuration have been deleted from the network feeds section. If a feed configuration appears in the network feeds, it will overwrite the default configuration. Now, we get all the available price feeds in a network called the [supportedFeeds](https://github.com/witnet/witnet-solidity-bridge/blob/2.0.x/contracts/interfaces/IFeeds.sol#L8) method.
Tommytrg
force-pushed
the
feat/price-feed-router
branch
from
bfc2264 to
26dda67
Compare
gabaldon
approved these changes
Feb 23, 2024
| @@ -65,6 +66,7 @@ export class ResultRequestRepository { | |||
| async getLastResult ( | |||
| feedFullName: string | |||
| ): Promise<ResultRequestDbObjectNormalized | null> { | |||
| console.log('inside getLastResult with feedFullname', feedFullName) | |||
| console.log(`Error in getLastResult: ${feedFullName}`, e) | ||
| return null | ||
| }) | ||
| console.log(lastResultRequest) |
|
|
||
| describe('NetworkRouter', () => { | ||
| // FIXME: web3 library is not working with jest. It works if use use vitest instead. | ||
| it.skip('should fetch network contract', async () => { |
packages/ui/components/Main.vue
Outdated
| @@ -147,6 +147,8 @@ export default { | |||
| this.currentPage = val | |||
| }, | |||
| setCurrentNetwork(options) { | |||
| console.log('options', options) | |||
packages/ui/components/Main.vue
Outdated
| @@ -147,6 +147,8 @@ export default { | |||
| this.currentPage = val | |||
| }, | |||
| setCurrentNetwork(options) { | |||
| console.log('options', options) | |||
| console.log('this.$route.params.network', this.$route) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for networks using WitnetFeeds contract
WitnetPriceRouterwithlistenLegacyPriceRouterand the new network usingWitnetFeedswithlistenWitnetPriceFeeds.legacy: truein the network configuration. Also, the file configuration has been updated to include the feed key. This new key consists of a map with the default values of the existing price feeds. According to that, the price feeds deployed using the default configuration have been deleted from the network feeds section. If a feed configuration appears in the network feeds, it will overwrite the default configuration. Now, we get all the available price feeds in a network called the supportedFeeds method.