New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MODEXP precompile success validation #5

Open

k06a wants to merge 1 commit into witnet:master from k06a:fix/modexp-success

k06a commented Sep 21, 2023 •

edited

Loading

MODEXP precompile always return success, but returndatasize() is 0 on failure.

Few more things to consider:

Include sub(n, 2) underflow check into success: success := and(gt(n, 1), eq(returndatasize(), 0x20))
Using 0 instead of freemem for call output memory pointer will be few gas cheaper


          Fix MODEXP precompile success validation

503c571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet