Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make asides less prominent #2659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

illright
Copy link

@illright illright commented Dec 7, 2024

Description

Related to #1701

This PR changes the appearance of aside blocks to make them stand out less. This was done by changing the -low version of the color palette to be less prominent. This change also affected the Card component.

I based my changes off of HiDeoo's WIP branch, but left off some changes:

  • decided not to round the corners of asides, since this is something that should be done separately and consistently
  • decided not to reduce the icon size because it didn't seem necessary
  • instead of using color-mix to add transparency to existing -low colors, I decided to change the low colors to keep consistency
Screenshots of the before/after for asides and cards in dark/light mode
BeforeAfter
Asides (dark)imageimage
Asides (light)image image
Cards (dark) image image
Cards (light) image image

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 7, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 83118bf
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6754855789714f00083ce481
😎 Deploy Preview https://deploy-preview-2659--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Dec 7, 2024

🦋 Changeset detected

Latest commit: 83118bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and your other PRs @illright!

As a heads up, the changes proposed in #1701 were not 100% finalised/agreed upon, so a review may take a bit of time.

We’re currently focusing our efforts on getting the Astro v5-compatible release of Starlight ready, so please understand if it takes some time to get back to you on these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants