fix: boolean data attributes

https://5-0-0-beta.docs.astro.build/en/guides/upgrade-to/v5/#changed-non-boolean-html-attribute-values
withastro · Nov 17, 2024 · 214d8b4 · 214d8b4
1 parent 6583163
commit 214d8b4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/packages/starlight/components/Page.astro b/packages/starlight/components/Page.astro
@@ -35,16 +35,14 @@ const pagefindEnabled =
 	Astro.props.entry.slug !== '404' &&
 	!Astro.props.entry.slug.endsWith('/404') &&
 	Astro.props.entry.data.pagefind !== false;
+
+const dataAttributes: DOMStringMap = { 'data-theme': 'dark' };
+if (Boolean(Astro.props.toc)) dataAttributes['data-has-toc'] = '';
+if (Astro.props.hasSidebar) dataAttributes['data-has-sidebar'] = '';
+if (Boolean(Astro.props.entry.data.hero)) dataAttributes['data-has-hero'] = '';
 ---
 
-<html
-	lang={Astro.props.lang}
-	dir={Astro.props.dir}
-	data-has-toc={Boolean(Astro.props.toc)}
-	data-has-sidebar={Astro.props.hasSidebar}
-	data-has-hero={Boolean(Astro.props.entry.data.hero)}
-	data-theme="dark"
->
+<html lang={Astro.props.lang} dir={Astro.props.dir} {...dataAttributes}>
 	<head>
 		<Head {...Astro.props} />
 		<style>

diff --git a/packages/starlight/components/Search.astro b/packages/starlight/components/Search.astro
@@ -12,12 +12,12 @@ const pagefindTranslations = {
 			.map(([key, value]) => [key.replace('pagefind.', ''), value])
 	),
 };
+
+const dataAttributes: DOMStringMap = { 'data-translations': JSON.stringify(pagefindTranslations) };
+if (project.trailingSlash === 'never') dataAttributes['data-strip-trailing-slash'] = '';
 ---
 
-<site-search
-	data-translations={JSON.stringify(pagefindTranslations)}
-	data-strip-trailing-slash={project.trailingSlash === 'never'}
->
+<site-search class={Astro.props.class} {...dataAttributes}>
 	<button
 		data-open-modal
 		disabled