Make nsq-cluster work on ruby 2.7-3.2 / arm64 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chen-anders
force-pushed
the
anders/make-work-on-modern-ruby
branch
2 times, most recently
from
f513791 to
5ddd9b4
Compare
michaelorr
approved these changes
Nov 27, 2023
spec/spec_helper.rb
Outdated
| @@ -19,5 +20,5 @@ | |||
| end | |||
|
|
|||
| RSpec.configuration.before :each do | |||
| FakeWeb.allow_net_connect = %r[^https?://#{Regexp.escape('127.0.0.1')}.*] | |||
| #FakeWeb.allow_net_connect = %r[^https?://#{Regexp.escape('127.0.0.1')}.*] | |||
There was a problem hiding this comment.
Just remove this block instead of commenting?
spec/spec_helper.rb
Outdated
| @@ -10,7 +11,7 @@ | |||
|
|
|||
| require 'nsq-cluster' | |||
|
|
|||
| require 'fakeweb' | |||
| #require 'fakeweb' | |||
.github/workflows/run-tests.yml
Outdated
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| which nsqd |
There was a problem hiding this comment.
Is there a reason to be suspicious of the prior step?
There was a problem hiding this comment.
yeah - there was some debugging I had to do - I think the tests that ran in the subsequent step weren't accepting the modified PATH (vs installing NSQ binaries into the /usr/local/bin path) in parts of my debugging - I think I can get rid of the step
chen-anders
force-pushed
the
anders/make-work-on-modern-ruby
branch
from
15bf525 to
3d91ce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to make nsq-cluster work on newer Ruby versions / arm machines (or at least make the specs fully runnable on these versions).