Skip to content

Commit

Permalink
Merge pull request godotengine#94506 from Jordyfel/handle-gltf-bin-mi…
Browse files Browse the repository at this point in the history
…ssing

Fix handling of missing bin file in gltf separate
  • Loading branch information
akien-mga committed Jul 18, 2024
2 parents 60966f5 + 416e63a commit ff8a278
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion modules/gltf/gltf_document.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -789,8 +789,9 @@ Error GLTFDocument::_parse_buffers(Ref<GLTFState> p_state, const String &p_base_
ERR_FAIL_COND_V(p_base_path.is_empty(), ERR_INVALID_PARAMETER);
uri = uri.uri_decode();
uri = p_base_path.path_join(uri).replace("\\", "/"); // Fix for Windows.
ERR_FAIL_COND_V_MSG(!FileAccess::exists(uri), ERR_FILE_NOT_FOUND, "glTF: Binary file not found: " + uri);
buffer_data = FileAccess::get_file_as_bytes(uri);
ERR_FAIL_COND_V_MSG(buffer.is_empty(), ERR_PARSE_ERROR, "glTF: Couldn't load binary file as an array: " + uri);
ERR_FAIL_COND_V_MSG(buffer_data.is_empty(), ERR_PARSE_ERROR, "glTF: Couldn't load binary file as an array: " + uri);
}

ERR_FAIL_COND_V(!buffer.has("byteLength"), ERR_PARSE_ERROR);
Expand Down

0 comments on commit ff8a278

Please sign in to comment.