Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json data deserialization) #WPB-12153 #113

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix(json data deserialization) #WPB-12153 #113

merged 2 commits into from
Nov 27, 2024

Conversation

spoonman01
Copy link
Contributor

  • Bump version to 1.7.2

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Failed to deserialize any Payload

Causes (Optional)

Custom deserializer being too strict

Solutions

Allow any field to be null in custom deserializer


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@spoonman01 spoonman01 requested a review from a team as a code owner November 27, 2024 10:16
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Nov 27, 2024
@spoonman01 spoonman01 merged commit 9b19b7d into master Nov 27, 2024
3 checks passed
@alexandreferris alexandreferris deleted the WPB-12153 branch November 27, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants