Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-mls-data-on-device-removed) #WPB-12155 #112

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

alexandreferris
Copy link
Contributor

  • Change usage of CoreCryptoCentral to CoreCrypto directly
  • Continue with usage of MLSClient (for now)
  • Add a new method to wipe client's MLS folder
  • Add tests

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

From upper lib usages (Legalhold) there was no way to properly wipe MLS data of removed client.

Causes (Optional)

Not implemented.

Solutions

  • Change usage from CoreCryptoCentral to CoreCrypto but keep usage of MlsClient just so we don't have to do the full migration (CoreCryptoCentral -> CoreCrypto) for now.
  • Add wipe() method to CryptoMlsClient that closes the client connection and removes the MLS folder and files

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Notes (Optional)

We first thought on using CoreCrypto original wipe() function, but unfortunately for now there is an issue with the said function so we are doing the wipe ourselves.
When the changes come live from CoreCrypto we can then update and remove our own logic to just call coreCrypto.wipe()

* Change usage of CoreCryptoCentral to CoreCrypto directly
* Continue with usage of MLSClient (for now)
* Add a new method to wipe client's MLS folder
* Add tests
@alexandreferris alexandreferris requested a review from a team as a code owner November 25, 2024 16:16
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Nov 25, 2024
@alexandreferris alexandreferris self-assigned this Nov 25, 2024
* Adjust KDocs for CryptoMlsClient
@alexandreferris alexandreferris merged commit 21c60c5 into master Nov 26, 2024
3 checks passed
@alexandreferris alexandreferris deleted the WPB-12155 branch November 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants