feat(remove-mls-data-on-device-removed) #WPB-12155 #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
From upper lib usages (Legalhold) there was no way to properly wipe MLS data of removed client.
Causes (Optional)
Not implemented.
Solutions
CoreCryptoCentral
toCoreCrypto
but keep usage ofMlsClient
just so we don't have to do the full migration (CoreCryptoCentral
->CoreCrypto
) for now.wipe()
method toCryptoMlsClient
that closes the client connection and removes the MLS folder and filesTesting
Test Coverage (Optional)
Notes (Optional)
We first thought on using
CoreCrypto
originalwipe()
function, but unfortunately for now there is an issue with the said function so we are doing the wipe ourselves.When the changes come live from CoreCrypto we can then update and remove our own logic to just call
coreCrypto.wipe()