Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP core-crypto mls client integration #107

Merged
merged 9 commits into from
Nov 8, 2024
Merged

WIP core-crypto mls client integration #107

merged 9 commits into from
Nov 8, 2024

Conversation

spoonman01
Copy link
Contributor

Add core-crypto-jvm and basic Kotlin libraries. #WPB-11223

  • Update Xenon from Java 11 to 17 (forced because of library version)
  • Add a CryptoMlsClient, wrapping core-crypto code in Java friendly Kotlin code
  • Adapt WireClientBase and MessageResourceBase to use MLS client
  • Implement decrypt MLS
  • Improve various api backend DTOs
  • Add project icon

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Add MLS support to Xenon

Solutions

Adopt core-crypto-jvm and wrap with custom file for Kotlin integration


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Add core-crypto-jvm and basic Kotlin libraries.

* Update Xenon from Java 11 to 17 (forced because of library version)
* Add a CryptoMlsClient, wrapping core-crypto code in Java friendly Kotlin code
* Adapt WireClientBase and MessageResourceBase to use MLS client
* Implement decrypt MLS
* Improve various api backend DTOs
* Add project icon
@spoonman01 spoonman01 self-assigned this Oct 29, 2024
@spoonman01 spoonman01 requested a review from a team as a code owner October 29, 2024 16:17
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Oct 29, 2024
* Add some more MLS operations to CryptoMlsClient
* Fix type in protocol names
* Change javadoc generation from maven-javadoc-plugin to Dokka
* Update Xenon to 1.6.3
…n conversations

* Add getUserConversations() WireApi contract
* Bump to 1.6.4
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 nitpick and one regarding the ClientUpdate on mls public key's key 😅

src/main/java/com/wire/xenon/WireAPI.java Outdated Show resolved Hide resolved
src/main/java/com/wire/xenon/WireClient.java Outdated Show resolved Hide resolved
@spoonman01 spoonman01 merged commit c7cfcbe into master Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants