Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qualified-id-deserialization) Fix wrong json field in QualifiedId #106

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

spoonman01
Copy link
Contributor

  • Bump to 1.6.2

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [] contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Bug in QualifiedId, unable to deserialize correctly from JSON

Causes (Optional)

Typo in JSON field

Solutions

Change "name" to "id" in deserialization


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@spoonman01 spoonman01 self-assigned this Sep 30, 2024
@marcoconti83 marcoconti83 merged commit f5960fa into master Sep 30, 2024
3 checks passed
@marcoconti83 marcoconti83 deleted the fix-qualifiedid-deserialization branch September 30, 2024 12:45
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants