[WPB-14310] Move domain registration guards to their respective subsystems #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: scale
zebot
added
the
ok-to-test
fisx
changed the title
fisx
force-pushed
the
WPB-14310-refactor-get-domain-reg
branch
4 times, most recently
from
153e1b3 to
50ae68a
Compare
fisx
force-pushed
the
WPB-14310-refactor-get-domain-reg
branch
from
50ae68a to
dc5e4ed
Compare
fisx
reviewed
Jan 29, 2025
Comment on lines
436
to
437
| . evalState [] | ||
| . inMemoryDomainRegistrationStoreInterpreter |
pcapriotti
force-pushed
the
WPB-14307-new-auth
branch
from
32d5f62 to
e47dd6a
Compare
- Return Maybe when trying to get domain registration - Move GuardEmailDomainRegistrationTeamInvitation to TeamInvitationSubsystem
fisx
force-pushed
the
WPB-14310-refactor-get-domain-reg
branch
from
db2ff49 to
3d1bf0e
Compare
battermann
approved these changes
Jan 30, 2025
Comment on lines
+896
to
+905
| interp :: | ||
| Sem | ||
| '[ DRS.DomainRegistrationStore, | ||
| State [DRS.StoredDomainRegistration], | ||
| TinyLog, | ||
| Error UserSubsystemError | ||
| ] | ||
| () -> | ||
| Either UserSubsystemError () | ||
| interp = run . runError . noopLogger . evalState [] . inMemoryDomainRegistrationStoreInterpreter |
There was a problem hiding this comment.
Should this interpreter be defined outside the test implementation, maybe?
There was a problem hiding this comment.
not sure. i think it's too special-purpose to be moved to MockInterpreters, and it's not very long or complex. i'd prefer to keep it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-14310
please read commit-by-commit.
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d