feat: Remove folder conversation filter when folder deleted - WPB-13905 #2228
+265
−352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
Currently when the folder filter is applied and the folder is deleted by removing its final conversation (locally or remotely), the folder filter remains leaving an empty conversation list.
This PR ensures the folder filter is removed when the folder is deleted. Specifically it:
ConversationFilterSelector
that updates the conversation filter based on system events rather than user selection - for now it only handles folder deletions but could handle the events if needed.ConversationDirectoryType.allFolders
withConversationDirectoryType.nonDeletedFolders
- the users of ConversationDirectoryType only care about folders that are not marked for deletion.Old
Simulator.Screen.Recording.-.Test.Device.-.2024-11-29.at.12.23.46.mp4
New
Simulator.Screen.Recording.-.Test.Device.-.2024-11-29.at.12.19.35.mp4
Testing
Please test on iPhone & iPad
Locally
+
icon5
Remotely
Checklist
[WPB-XXX]
.