Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove folder conversation filter when folder deleted - WPB-13905 #2225

Merged
merged 13 commits into from
Nov 29, 2024
Merged

feat: Remove folder conversation filter when folder deleted - WPB-13905 #2225

merged 13 commits into from
Nov 29, 2024

Commits on Nov 29, 2024

  1. Delete isFolderStatePersistenceEnabled which is hardcoded to false

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c7d4ca4 View commit details
    Browse the repository at this point in the history

  2. Remove Folder & Section related code

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    aea3abf View commit details
    Browse the repository at this point in the history

  3. Fix mutability of selectedFilterImage

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5394264 View commit details
    Browse the repository at this point in the history

  4. Replace ConversationDirectoryType.allFolders with `ConversationDire… 

    …ctoryType.nonDeletedFolders`
    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a47dccd View commit details
    Browse the repository at this point in the history

  5. Pass ConversationDirectoryType to ConversationDirectoryObserver methods

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    12b6b3a View commit details
    Browse the repository at this point in the history

  6. Introduce MainCoordinator.applyConversationFilter(_:) 

    We need a method to apply the filter with doing any navigation
    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    615b46c View commit details
    Browse the repository at this point in the history

  7. Introduce ConversationFilterSelector

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5e8874e View commit details
    Browse the repository at this point in the history

  8. Remove code related to collapsing sections

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d2a326d View commit details
    Browse the repository at this point in the history

  9. Remove mainCoordinator as a dependency from `ConversationFilterSele… 

    …ctor`
    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    ffdda00 View commit details
    Browse the repository at this point in the history

  10. Test ConversationFilterSelector

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    22e9fd6 View commit details
    Browse the repository at this point in the history

  11. Empty commit

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    2f8368e View commit details
    Browse the repository at this point in the history

  12. Test AnyMainCoordinator.applyConversationFilter

    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    24b1f72 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'release/cycle-3.114' into feat/remove-folder-filter-WPB… 

    …-13905-v2
    @samwyndham
    samwyndham committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    9651296 View commit details
    Browse the repository at this point in the history