Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable adding remote domain users - WPB-10789 #2177

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Nov 21, 2024

StoryWPB-10789 [iOS] Disable adding remote domain users in Proteus Conversations

Issue

Filter search result depends on the protocol of the conversation:

  • disable adding remote domain users in Proteus Conversations
  • do not show users from other domains in the conversation creation interface when Proteus is default protocol of the team.

Solution

We need to add conditions to filter out federated users in different parts: add members, create conversation, search users, open 1:1. For this reason, I created IsFederationSearchAllowedUseCase, which contains these conditions:

  • if the protocol of a conversation is Proteus, do not show users from other domains in the interface to add users;
  • if Proteus is the default protocol of the team, do not show users from other domains in the conversation creation interface.

Also, soon we will need to extend these conditions with another one, which is necessary for one of the customers.

Testing

  1. Create Proteus conversation.
  2. Try to add users with other domain.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Test Results

    4 files    703 suites   12m 23s ⏱️
5 549 tests 5 549 ✅ 0 💤 0 ❌
5 557 runs  5 557 ✅ 0 💤 0 ❌

Results for commit ee6ea68.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire marked this pull request as ready for review November 22, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant