-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable adding remote domain users - WPB-10789 #2177
Open
KaterinaWire
wants to merge
15
commits into
develop
Choose a base branch
from
feat/disable-adding-remote-domain-users-WPB-10789
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: disable adding remote domain users - WPB-10789 #2177
KaterinaWire
wants to merge
15
commits into
develop
from
feat/disable-adding-remote-domain-users-WPB-10789
+527
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
Activate Federation with MLS on Wire Cloud
label
Nov 21, 2024
Test Results 4 files 703 suites 12m 23s ⏱️ Results for commit ee6ea68. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Filter search result depends on the protocol of the conversation:
Proteus
ConversationsProteus
is default protocol of the team.Solution
We need to add conditions to filter out federated users in different parts: add members, create conversation, search users, open 1:1. For this reason, I created
IsFederationSearchAllowedUseCase
, which contains these conditions:Also, soon we will need to extend these conditions with another one, which is necessary for one of the customers.
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: