chore(close-potential-network-leaks)

[alexandreferris]

Some functions were propitious to leak the network response object from not closing them properly.

Added missing response.close() to:

• API.java
• LoginClient.java

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Some API functions were throwing this exception on the logs:

ConnectionPoolTimeoutException: Timeout waiting for connection from pool

But unfortunately we don't have the stack trace anymore.

Causes (Optional)

We forgot to call response.close(); on some functions.

Note: We either call response.close(); or response.readEntity(Something.class); so the network is properly closed.

Solutions

Add response.close(); to functions missing it in API.java and LoginClient.java

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud