Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(double-reading-response) #WPB-11546 #14

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(double-reading-response) #WPB-11546 #14

merged 1 commit into from
Oct 14, 2024

Conversation

spoonman01
Copy link
Contributor

Remove second reading of error body in downloadAsset #WPB-11546


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Could not report specific error on downloadAsset

Causes (Optional)

Difficulties debugging asset api call

Solutions

Read error body once


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@spoonman01 spoonman01 self-assigned this Oct 14, 2024
@spoonman01 spoonman01 requested a review from a team as a code owner October 14, 2024 13:15
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Oct 14, 2024
Copy link

sonarcloud bot commented Oct 14, 2024

@spoonman01 spoonman01 merged commit 5a2020a into master Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants