Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPERIMENTAL DO NOT MERGE: build: replace async-lock with tokio locks in core-crypto #766

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 15, 2024

  1. build: replace async-lock with tokio locks in core-crypto

    This is experimental work, the purpose of which is to see how hard
    it would be to just swap out the lock implementations. If all had
    gone well, then it would have been worthwhile to make this change
    for the `map` and `try_map` that `tokio`'s lock guards have, which
    could have improved the ergonomics of some of our internal methods.
    
    Unfortunately, the difficulty was more than trivial. While it took
    only a few minutes of mechanical work to swap out the imports and
    uses, this causes a handful of tests to fail. So it's not really
    worth proceeding further with this experiment until we've actually
    prioritized it.
    coriolinus committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c8998dc View commit details
    Browse the repository at this point in the history