Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "storm" option for the span property #57

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

webbati
Copy link
Contributor

@webbati webbati commented Jan 7, 2023

Now is not possible to set "storm" as span value and the builder plugin delete the value saving after you set it manually.

We also apply the "cssClass" property to the widget of the builder if "storm" value is selected for the span property, default class "col-sx-12 col-md-6" will be applied if nothing is set

@LukeTowers
Copy link
Member

We should probably call it manual instead, storm isn't really a special value that's treated any differently if I recall, it's just the use of any non-supported values that triggers the behaviours associated with setting span: storm.

@bennothommo
Copy link
Member

@LukeTowers you're right, also, it looks like auto doesn't do anything either - at the very least, I haven't found any code that directly targets it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants