finos#486 comments cleanup

willosborne · Oct 25, 2024 · c47c06c · c47c06c
1 parent 834d741
commit c47c06c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cli/src/commands/generate/components/instantiate.ts b/cli/src/commands/generate/components/instantiate.ts
@@ -28,7 +28,7 @@ export function instantiateGenericObject(definition: object, schemaDirectory: Sc
         const currentPath = appendPath(path, key);
         const renderedPath = renderPath(currentPath);
 
-        if (!instantiateAll && required && !required.includes(key) && key !== 'interfaces') { // TODO should we always do interfaces even if not required?
+        if (!instantiateAll && required && !required.includes(key) && key !== 'interfaces') { 
             logger.debug(`${renderedPath}: Skipping property ${key} as it is not marked as required.`);
             continue;
         }

diff --git a/cli/src/commands/generate/schema-directory.ts b/cli/src/commands/generate/schema-directory.ts
@@ -105,7 +105,6 @@ export class SchemaDirectory {
     public getDefinition(definitionReference: string) {
         this.logger.debug(`Resolving ${definitionReference} from schema directory.`);
         return this.getDefinitionRecursive(definitionReference, 'pattern', []);
-        // TODO propagate the required fields
     }
 
     /**