Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include year in session filter #223

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

williamsjokvist
Copy link
Owner

@williamsjokvist williamsjokvist commented Jan 3, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Corrected date parsing and formatting across sessions page and database queries
    • Updated session retrieval logic to handle date strings more accurately
  • Improvements

    • Enhanced date-based filtering and statistics gathering for session data
    • Improved consistency in date string processing between frontend and backend

Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces changes to how session data is handled in both the frontend (gui/src/pages/sessions.tsx) and backend (pkg/storage/sql/session.go) components. The modifications primarily focus on adjusting the date string parsing and formatting, switching from a month-year format to a year-month format. This change ensures consistent date handling across the application's session retrieval and statistics generation processes.

Changes

File Change Summary
gui/src/pages/sessions.tsx - Reordered date destructuring from [month, year] to [year, month]
- Updated session fetching logic to use full date string
- Modified effect dependencies to include monthIndex and months
pkg/storage/sql/session.go - Changed SQL date format from '%m-%Y' to '%Y-%m'
- Updated STRFTIME formatting in GetSessionsStatistics and GetSessions methods

Sequence Diagram

sequenceDiagram
    participant UI as Sessions Page
    participant Backend as Storage Service
    UI->>UI: Parse Date (Year-Month)
    UI->>Backend: Request Sessions with Formatted Date
    Backend->>Backend: Query Database with Year-Month Format
    Backend-->>UI: Return Session Data
Loading

Poem

🐰 A Rabbit's Date Dance 🕰️

From month-year to year-month we leap,
Dates now dance in a new rhythmic sweep,
SQL queries twirl with grace so bright,
Sessions align, everything just right!
Code hops forward, no more delay! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c4f748 and bc1426b.

📒 Files selected for processing (2)
  • gui/src/pages/sessions.tsx (1 hunks)
  • pkg/storage/sql/session.go (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@williamsjokvist williamsjokvist marked this pull request as ready for review January 3, 2025 23:35
@williamsjokvist williamsjokvist requested a review from tifye as a code owner January 3, 2025 23:35
@williamsjokvist williamsjokvist merged commit 2733cba into master Jan 3, 2025
3 checks passed
@williamsjokvist williamsjokvist deleted the fix/session-years branch January 3, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant