Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.3.4 #79

Merged
merged 35 commits into from
Nov 13, 2023
Merged

Release/0.3.4 #79

merged 35 commits into from
Nov 13, 2023

Conversation

picciama
Copy link
Contributor

@picciama picciama commented Nov 10, 2023 •
edited
Loading

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

See release notes

Technical details

Additional context

“Karim and others added 30 commits October 2, 2023 15:55
Added a new comit.py file.
3a3dd72
@picciama
fixed instrumentConfigurationRef missing
0ed85b8
Merge branch 'development' of github.com:wilhelm-lab/spectrum_io into…
40b352e 
… development
@picciama
Merge branch 'development' into fix/mzml_instrumentConfigurationRef
2510beb
added empty parser file for sage
3a01722
@picciama
cleaned up and remove filter string
d6994dc
@picciama
added unittests + cleanup for msraw
4a60a9c
@picciama
fixed return type
398ce26
added sage.py parser - tmt label in the update_columns_for_prosit fun…
85e8900 
…ction
added a few lines and edits for Sage integration
c781611
added final working version of sage. fixed modifications not yet impl…
602bbd5 
…emented.
@picciama
also read collision energy from mzml
ecdf3c1
@picciama
added a workaround for misisng collision column
96a67d1
@picciama
moved msfragger_to_internal to fundamentals
07f8d28
added a minor change
a0e4a11
@picciama
added support for tmt for msfragger
c1f4b4a
@picciama
cleanup, docstring fixing
d27eddc
@picciama
added mock unit test
ec7df40
@picciama
Merge branch 'development' into feature/sage
8a632d4
@picciama
change back to state of development branch
d9dd45f
added
06c6bbb
@picciama
remove temporary fix
550b669
@picciama
new version containing COLLISION_ENERGY column
f19dd9b
Merge branch 'feature/sage' of github.com:wilhelm-lab/spectrum_io int…
4205c0d 
…o feature/sage
added sage data out
55279ac
@picciama
fixed reading and testing sage
2a0221a
@picciama
updated dependencies
20ff688
@picciama
Merge pull request #75 from wilhelm-lab/fix/mzml_instrumentConfigurat…
2f5c0e8 
…ionRef

fixed instrumentConfigurationRef missing
@picciama
Merge branch 'development' into feature/sage
91f3d88
@picciama
Merge branch 'development' into feature/msfragger_mods_tmt
31ca434
@picciama picciama requested a review from arminsl November 10, 2023 17:24
@picciama picciama merged commit 6d28b8e into main Nov 13, 2023
79 checks passed
@picciama picciama deleted the release/0.3.4 branch December 15, 2023 17:11
@picciama picciama restored the release/0.3.4 branch December 15, 2023 17:11
@picciama picciama deleted the release/0.3.4 branch December 15, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminsl arminsl arminsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picciama @arminsl