Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/xl percolator gen features #153

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Fix/xl percolator gen features #153

merged 6 commits into from
Oct 26, 2024

Conversation

mostafakalhor
Copy link
Contributor

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Technical details

Additional context

@github-actions github-actions bot added the bug Something isn't working label Oct 26, 2024
picciama
picciama requested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@picciama picciama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the commented out code.

spectrum_fundamentals/metrics/percolator.py Outdated Show resolved Hide resolved
@picciama picciama merged commit 8dd1b9c into development Oct 26, 2024
26 checks passed
@picciama picciama deleted the fix/xl_percolator_gen_features branch October 26, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picciama picciama picciama approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mostafakalhor @picciama