Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/0.7.2 #130

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Patch/0.7.2 #130

merged 2 commits into from
Aug 6, 2024

Conversation

picciama
Copy link
Contributor

@picciama picciama commented Aug 6, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  • removed old and obsolete compute_ion_masses function
  • cleanup of constants and modification to mass mapping by supplying only unimod to mass dictionary

Technical details

Additional context

@picciama picciama changed the base branch from development to main August 6, 2024 22:33
@picciama picciama merged commit 6f0465f into main Aug 6, 2024
46 checks passed
@picciama picciama deleted the patch/0.7.2 branch August 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@picciama