Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of hierarchical class structure: New API structure #81

Closed
picciama opened this issue Jun 25, 2023 · 0 comments · Fixed by #108
Closed

Removal of hierarchical class structure: New API structure #81

picciama opened this issue Jun 25, 2023 · 0 comments · Fixed by #108
Assignees
Labels
enhancement New feature or request

Comments

@picciama
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The hierarchical class structure of oktoberfest does not allow execution of individual functions within the pipeline out of the box. This makes bugfixing, investigation and enhancement difficult.
Plus, it is not the most userfriendly way we could do this and it is difficult to extend the existing code base.

Describe the solution you would like
Removal of the hierarchical class structure, that is basically only there to have shared access to the spectral library object.
Instead, a linear API, that executes static functions that return the spectral library object after modifying it.
In addition, high level functions that execute all of these functions to keep the current way of executing oktoberfest.

Tasks:

  • come up with a structure of functions
  • check where and how submodules should be organised
  • cleanup the code

Additional context
Making oktoberfest code base cleaner, future proof and lightweight

@picciama picciama added the enhancement New feature or request label Jun 25, 2023
@picciama picciama linked a pull request Aug 11, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants