Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmtpro flag only adds tag to lysines, not n-term. #123

Closed
ChrisMcGann opened this issue Sep 11, 2023 · 2 comments · Fixed by #108 or wilhelm-lab/spectrum_fundamentals#76
Closed

tmtpro flag only adds tag to lysines, not n-term. #123

ChrisMcGann opened this issue Sep 11, 2023 · 2 comments · Fixed by #108 or wilhelm-lab/spectrum_fundamentals#76
Assignees
@picciama
Labels
bug Something isn't working

Comments

@ChrisMcGann
Copy link

Hello,
Using the tmtpro flag in a config file only adds the tag to lysine. Attaching config file and input .csv. Thanks!

prosit_input_minimal.zip
@ChrisMcGann ChrisMcGann added the bug Something isn't working label Sep 11, 2023
@picciama picciama self-assigned this Sep 12, 2023
@picciama
Copy link
Contributor

picciama commented Sep 12, 2023 •
edited
Loading

Thanks for pointing this out. I was able to reproduce this and know the reason for it (wrong order of modified sequence processing functions). It will be fixed as part of the new API release.

@picciama picciama linked a pull request Sep 12, 2023 that will close this issue
Feature/api #108
Merged
4 tasks
@ChrisMcGann
Copy link
Author

Awesome, glad to hear it.

@picciama picciama linked a pull request Sep 19, 2023 that will close this issue
Fix/tmt modstring wilhelm-lab/spectrum_fundamentals#76
Merged
4 tasks
@picciama picciama reopened this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picciama picciama

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/api wilhelm-lab/oktoberfest
Fix/tmt modstring wilhelm-lab/spectrum_fundamentals
2 participants
@picciama @ChrisMcGann