fix proguard issue

wildfirechat · Dec 18, 2020 · b4ee00e · b4ee00e
1 parent e88da25
commit b4ee00e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/chat/proguard-rules.pro b/chat/proguard-rules.pro
@@ -74,6 +74,10 @@
     <init>(...);
 }
 
+-keepclassmembers class cn.wildfirechat.message.MessageContent {
+    encode();
+}
+
 -keep class net.sourceforge.pinyin4j.** { *;}
 
 

diff --git a/client/src/main/java/cn/wildfirechat/remote/ChatManager.java b/client/src/main/java/cn/wildfirechat/remote/ChatManager.java
@@ -1327,12 +1327,13 @@ private void validateMessageContent(Class<? extends MessageContent> msgContentCl
             throw new IllegalArgumentException(className + ", custom messageContent class must have a default constructor，自定义消息必须要有一个默认的无参构造函数，请参考TextMessageContent.java");
         }
 
-        try {
-            msgContentClazz.getDeclaredMethod("encode");
-        } catch (NoSuchMethodException e) {
-            e.printStackTrace();
-            throw new IllegalArgumentException(className + ", custom messageContent class must override encode，自定义消息必须覆盖encode方法，并调用super.encode()，请参考TextMessageContent.java");
-        }
+        // 建议打开，以便对自定义消息的合法性进行检查
+//        try {
+//            msgContentClazz.getDeclaredMethod("encode");
+//        } catch (NoSuchMethodException e) {
+//            e.printStackTrace();
+//            throw new IllegalArgumentException(className + ", custom messageContent class must override encode，自定义消息必须覆盖encode方法，并调用super.encode()，请参考TextMessageContent.java");
+//        }
 
         try {
             Field creator = msgContentClazz.getDeclaredField("CREATOR");