Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker file for web_checking.py #31

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Conversation

Szuumii
Copy link
Collaborator

@Szuumii Szuumii commented Sep 7, 2023

Description

This PR adds a Dockerfile 🐳 building web_checking 🌐 app

Copy link
Owner

@wiktorlazarski wiktorlazarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates 🚀! Huuuge kudos for taking over the "more mature" release part of the project 🤩.

I left a few comments/questions here and there about the things I dispute. Lemme know what you think 🤗.

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Owner

@wiktorlazarski wiktorlazarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes 🚀! Looks sharp 🦈🤗. A few last things to resolve before we can merge it.

@@ -16,6 +16,10 @@ ______________________________________________________________________

</div>

## 🔍 Preview
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Quick model spot-checking, wdyt?

Copy link
Collaborator Author

@Szuumii Szuumii Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick with preview, but I leave the decision to you

README.md Outdated Show resolved Hide resolved

RUN pip3 install -e .

ENTRYPOINT exec python -m streamlit run apps/web_checking.py --server.port=$PORT --server.address=0.0.0.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: would that be possible to make this Dockerfile slightly more generic by parametrising Streamlit app that should be started? I'm thinking about structure that looks something like:

Suggested change
ENTRYPOINT exec python -m streamlit run apps/web_checking.py --server.port=$PORT --server.address=0.0.0.0
ENTRYPOINT exec python -m streamlit run apps/$APP_SCRIPT --server.port=$PORT --server.address=0.0.0.0

wdyt?

Copy link
Collaborator Author

@Szuumii Szuumii Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very neat idea! However, currently there is absolutely no need for that since we ONLY want web_checking.py to run in the cloud and this change would force us to reconfigure current cloud deployment which I'm against.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense if we'd have another 'deployable' version e.g backend API (we can think about it in the future)

Co-authored-by: Wiktor Łazarski <[email protected]>
Copy link
Owner

@wiktorlazarski wiktorlazarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me. Thanks for all the explanations 🤗. Sending my approval
image

@Szuumii Szuumii merged commit ebca50e into main Sep 22, 2023
1 check passed
@Szuumii Szuumii deleted the jszumski/Dockerfile branch September 22, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants