-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker file for web_checking.py #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates 🚀! Huuuge kudos for taking over the "more mature" release part of the project 🤩.
I left a few comments/questions here and there about the things I dispute. Lemme know what you think 🤗.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes 🚀! Looks sharp 🦈🤗. A few last things to resolve before we can merge it.
@@ -16,6 +16,10 @@ ______________________________________________________________________ | |||
|
|||
</div> | |||
|
|||
## 🔍 Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Quick model spot-checking, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd stick with preview, but I leave the decision to you
|
||
RUN pip3 install -e . | ||
|
||
ENTRYPOINT exec python -m streamlit run apps/web_checking.py --server.port=$PORT --server.address=0.0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question: would that be possible to make this Dockerfile slightly more generic by parametrising Streamlit app that should be started? I'm thinking about structure that looks something like:
ENTRYPOINT exec python -m streamlit run apps/web_checking.py --server.port=$PORT --server.address=0.0.0.0 | |
ENTRYPOINT exec python -m streamlit run apps/$APP_SCRIPT --server.port=$PORT --server.address=0.0.0.0 |
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a very neat idea! However, currently there is absolutely no need for that since we ONLY want web_checking.py
to run in the cloud and this change would force us to reconfigure current cloud deployment which I'm against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make sense if we'd have another 'deployable' version e.g backend API (we can think about it in the future)
Co-authored-by: Wiktor Łazarski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR adds a
Dockerfile
🐳 building web_checking 🌐 app