T383359 #5145
Open
T383359 #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[YiR] Update donate button displaying logic on saved articles slide
…-bugfix Revert "[YiR] Update donate button displaying logic on saved articles slide"
Revert "[YiR] Analytics update"
l-olson1214
requested review from
a team and
mazevedofs
and removed request for
a team
tonisevener
requested changes
Jan 11, 2025
There was a problem hiding this comment.
@l-olson1214 Definitely better! Testing Turkish looked good. I notice the two links in the text on these slides do not link to the German web view, despite there being German translations in that web view.
It navigates to English, which isn't too bad, the user can just tap German from the web view if they need to (though it will kick them out of the app). Better than a broken page like it was fur Turkish before.
Also can you fix the diff here, looks like some reverts from main slipped in. If it's easier to close this PR/branch and open a new one against the 7.6.3 branch, that's fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T383359
Notes
Test Steps
Screenshots/Videos