Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YiR] Intro slide VoiceOver fix #5139

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[YiR] Intro slide VoiceOver fix #5139

merged 2 commits into from
Jan 10, 2025

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T378129

Notes

  • While I was not able to reproduce the bug Anthony found, accessing the buttons in this VStack was a little inconsistent. I signaled the stack as containing children and, in my testing, it was easier to access the buttons

Test Steps

  1. With VoiceOver on, explore the initial slide
  2. You should be able to access all the elements and navigate to the learn more webview when double-tapping the Learn More button

@mazevedofs mazevedofs requested review from a team and tonisevener and removed request for a team January 10, 2025 16:28
@mazevedofs mazevedofs changed the base branch from main to 7.6.3 January 10, 2025 16:51
tonisevener
tonisevener approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonisevener tonisevener merged commit 98e173f into 7.6.3 Jan 10, 2025
4 checks passed
@tonisevener tonisevener deleted the yir-button-accessibility-bugfix branch January 10, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazevedofs @tonisevener