Update badge delegate

[l-olson1214]

Phabricator:
https://phabricator.wikimedia.org/T382932

Notes

Test Steps

1. Check on a fresh install the notifications, make sure they go away for logged out users upon clicking

Screenshots/Videos

[mazevedofs]

It's not clearing the badge state for me.
Other than just calling this upon clicking, we have logic in place here to verify if the user has seen the first slide.
Perhaps in this situation, you need to create a separate check for logged out users that clears this state after just clicking the item in menu.
We still need the current logic in place to logged-in users, so a different check would work better in this case.

edit: You don't need another delegate method, but work on YiRDataController whether you should clear the badge immediately or still check if the user saw the first slide

[mazevedofs]

looks good!