Merge pull request #4453 from wikimedia/talk-page-archives-error

Do not prevent users from viewing talk page if summary call fails
wikimedia · Jan 23, 2023 · 0a31817 · 0a31817
2 parents 7629089 + b30b9ea
commit 0a31817
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Wikipedia/Code/TalkPageArchivesViewController.swift b/Wikipedia/Code/TalkPageArchivesViewController.swift
@@ -31,7 +31,7 @@ class TalkPageArchivesViewController: UIViewController, Themeable, ShiftingTopVi
 
     lazy var barView: ShiftingNavigationBarView = {
         let items = navigationController?.viewControllers.map({ $0.navigationItem }) ?? []
-        return ShiftingNavigationBarView(shiftOrder: 1, navigationItems: items, hidesOnScroll: true, popDelegate: self)
+        return ShiftingNavigationBarView(shiftOrder: 1, navigationItems: items, hidesOnScroll: false, popDelegate: self)
     }()
 
     init(viewModel: TalkPageArchivesViewModel, theme: Theme) {

diff --git a/Wikipedia/Code/TalkPageDataController.swift b/Wikipedia/Code/TalkPageDataController.swift
@@ -1,5 +1,6 @@
 import Foundation
 import WMF
+import CocoaLumberjackSwift
 
 /// Class that coordinates network fetches for talk pages.
 /// Leans on file persistence for offline mode as-needed.
@@ -51,7 +52,9 @@ class TalkPageDataController {
 
         fetchArticleSummaryIfNeeded(dispatchGroup: group) { articleSummary, errors in
             finalArticleSummary = articleSummary
-            finalErrors.append(contentsOf: errors)
+            if errors.count > 0 {
+                DDLogError("Error fetching article summary for talk page header. Ignoring.")
+            }
         }
 
         fetchLatestRevisionID(dispatchGroup: group) { revisionID in