Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save confidence intervals as a dictionary #163

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

pberkes
Copy link
Collaborator

@pberkes pberkes commented Nov 16, 2024

Fix #136
Fix #142

Confidence intervals are not saved as

>>> result.confidence_intervals['threshold'] 
{
 '0.95' : [0.0041551724137931035, 0.005110079575596817],
 '0.9' : [0.004218832891246685, 0.005110079575596817],
 '0.68' : [0.004346153846153846, 0.004982758620689655]
}

I propose to use '0.95' instead of '95%', because in my experience the latter would mean that we'll be writing forever code that converts '95%' into 0.95 and viceversa

Copy link
Collaborator

@guillermoaguilar guillermoaguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all look good to me.

@pberkes pberkes merged commit 4dbd74f into wichmann-lab:main Nov 21, 2024
6 checks passed
@pberkes pberkes deleted the confidence-intervals branch November 21, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the CI_method stripes change format of confidence intervals structure
2 participants