Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to compare matlab and python versions #61

Open
dekuenstle opened this issue Oct 21, 2021 · 2 comments
Open

Tests to compare matlab and python versions #61

dekuenstle opened this issue Oct 21, 2021 · 2 comments
Assignees
@dekuenstle
Labels
enhancement help wanted
Milestone
v4.3

Comments

@dekuenstle
Copy link
Member

  1. Specify multiple configurations & data
  2. Run these matlab psignifit and store the result
  3. Compare the fitted parameters in python psignifit with the stored matlab fit.
@dekuenstle dekuenstle mentioned this issue Nov 12, 2021
Closed
@dekuenstle
Copy link
Member Author

This is a collection of test cases and results on the matlab psignifit psignifit_test_cases.zip

@dekuenstle dekuenstle added this to the v4.3 milestone Oct 7, 2024
@dekuenstle dekuenstle self-assigned this Oct 7, 2024
@dekuenstle
Copy link
Member Author

dekuenstle commented Oct 7, 2024 •
edited
Loading

Update/timeline:
Currently, there remain some numerical differences between MATLAB and Python CI (#66), which might result from a bug in the prior width (#150).

After #150 is resolved, #66 should be cleaned up (e.g., the unnecessary naming changes should be reverted) and show no relevant numerical differences left, ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dekuenstle dekuenstle

Labels
enhancement help wanted
Projects
None yet
Milestone
v4.3
Development

No branches or pull requests
1 participant
@dekuenstle