Add support for aws session token #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whywaita
reviewed
Dec 22, 2023
README.md
Outdated
| aws-endpoint: https://example.com # Optional | ||
| aws-s3-bucket-endpoint: false # Optional | ||
| aws-s3-force-path-style: true # Optional | ||
| aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }} # Optional |
There was a problem hiding this comment.
Please write How to generate token e.g. generated token from aws-actions/configure-aws-credentials
There was a problem hiding this comment.
Done! Thanks for your work on the S3 backed version of the cache action.
|
I released https://github.com/whywaita/actions-cache-s3/releases/tag/v3.0.4 for your change. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for supplying AWS Session Token as input, so assuming roles from aws-actions/configure-aws-credentials works correctly
Motivation and Context
I was unable to access the S3 bucket without this token supplied when assuming a role through
aws-actions/configure-aws-credentialsHow Has This Been Tested?
Pointed my workflow at my own branch and saw that accessing the S3 bucket now worked
Types of changes
Checklist: