Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix lint warnings #97

Merged
merged 1 commit into from
Aug 3, 2024
Merged

lint: fix lint warnings #97

merged 1 commit into from
Aug 3, 2024

Conversation

jinyoungbang
Copy link
Contributor

What does this PR do?

  • Fixed major lint warnings and dead code

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@jinyoungbang jinyoungbang added the improvement Enhancements label Jul 28, 2024
@jinyoungbang jinyoungbang requested a review from wderocco8 July 28, 2024 18:45
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1873 1373 73% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/api/applicants.py 100% 🟢
chalicelib/api/insights.py 100% 🟢
chalicelib/api/listings.py 88% 🟢
chalicelib/s3.py 41% 🟢
chalicelib/services/AccountabilityService.py 47% 🟢
chalicelib/services/EventsMemberService.py 40% 🟢
chalicelib/services/InsightsService.py 94% 🟢
chalicelib/services/ListingService.py 71% 🟢
chalicelib/utils.py 100% 🟢
tests/api/test_applicants.py 100% 🟢
tests/api/test_events_members.py 100% 🟢
tests/api/test_events_rush.py 100% 🟢
tests/api/test_insights.py 100% 🟢
tests/api/test_listings.py 100% 🟢
tests/services/test_applicant_service.py 100% 🟢
tests/services/test_events_member_service.py 100% 🟢
tests/services/test_insights_service.py 100% 🟢
tests/services/test_listing_service.py 100% 🟢
tests/test_decorators.py 100% 🟢
tests/test_dynamodb.py 100% 🟢
TOTAL 89% 🟢

updated for commit: 255f481 by action🐍

Copy link
Contributor

@wderocco8 wderocco8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Do you mind me asking how the linting works btw? Do you have to run a specific command to perform a lint?

@jinyoungbang
Copy link
Contributor Author

looks good! Do you mind me asking how the linting works btw? Do you have to run a specific command to perform a lint?

@wderocco8 You can use the ruff check command! More here: https://docs.astral.sh/ruff/linter/

@jinyoungbang jinyoungbang merged commit ed37246 into dev/v1.0 Aug 3, 2024
1 check passed
@jinyoungbang jinyoungbang deleted the fix/ruff-lint branch August 3, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants