Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Update Member API + Implement Member API unit tests #96

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

jinyoungbang
Copy link
Contributor

What does this PR do?

  • Created get member by id API

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@jinyoungbang jinyoungbang added the feature New Features label Jul 27, 2024
Copy link

github-actions bot commented Jul 27, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2004 1501 75% 70% 🟢

New Files

File Coverage Status
tests/api/test_members.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
chalicelib/api/members.py 100% 🟢
chalicelib/services/MemberService.py 36% 🟢
tests/test_decorators.py 100% 🟢
tests/test_dynamodb.py 100% 🟢
TOTAL 84% 🟢

updated for commit: 70dea1a by action🐍

@jinyoungbang jinyoungbang changed the title feat: Implement APIs needed for Family Tree feat: Create Update Member API + Implement Member API unit tests Jul 28, 2024
@jinyoungbang jinyoungbang added the improvement Enhancements label Jul 28, 2024
@jinyoungbang jinyoungbang marked this pull request as ready for review July 28, 2024 18:15
@jinyoungbang jinyoungbang requested a review from wderocco8 July 28, 2024 18:15
@jinyoungbang jinyoungbang merged commit 7b2dac9 into dev/v1.0 Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Features improvement Enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant