Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/analytics detail view zap #101

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Feat/analytics detail view zap #101

merged 3 commits into from
Aug 15, 2024

Conversation

wderocco8
Copy link
Contributor

What does this PR do?

Changed get_rush_event function to dynamically return event details like code or attendees depending on the flags set (default is neither of them returned).

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@wderocco8 wderocco8 added the refactor Code Refactor label Aug 15, 2024
@wderocco8 wderocco8 requested a review from jinyoungbang August 15, 2024 01:19
jinyoungbang
jinyoungbang approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2034 1505 74% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chalicelib/api/events_rush.py 94% 🟢
chalicelib/services/EventsRushService.py 15% 🟢
tests/api/test_events_rush.py 100% 🟢
TOTAL 70% 🟢

updated for commit: e343ecf by action🐍

@wderocco8 wderocco8 merged commit 0217dbe into dev/v1.0 Aug 15, 2024
1 check passed
@wderocco8 wderocco8 deleted the feat/analytics-detail-view-ZAP branch August 15, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinyoungbang jinyoungbang jinyoungbang approved these changes

Assignees
No one assigned
Labels
refactor Code Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wderocco8 @jinyoungbang