Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daniel Chen onboarding #12

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Daniel Chen onboarding #12

merged 1 commit into from
Jan 21, 2024

Conversation

dan1elchen
Copy link
Contributor

@dan1elchen dan1elchen commented Jan 21, 2024

Purpose of PR

Added authentication for Daniel Chen

Type of change

  • User Update: Adding/Delete/Modifying users in vault

  • Fix: Bug fix (non-breaking change which fixes an issue)

  • Refactor: Any code refactoring

  • Chore: technical debt, workflow improvements

  • Feature: New feature (non-breaking change which adds functionality)

  • Documentation: This change requires a documentation update

Additional Comments

@dan1elchen
Copy link
Contributor Author

@jinyoungbang

Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jinyoungbang jinyoungbang merged commit 0d65ba6 into main Jan 21, 2024
1 check passed
@jinyoungbang jinyoungbang deleted the dc branch January 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants