Hotfix/url bugs and rush threshold #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyoungbang
requested changes
Sep 17, 2024
utils/getRushThreshold.ts
Outdated
| const attendedRemaining = remainingEvents.filter((event) => events[event]).length; | ||
|
|
||
| // Check if the rush threshold is met: at least 1 mandatory event and 2 other events | ||
| return attendedMandatory && attendedRemaining >= 2; |
There was a problem hiding this comment.
Can we make the count 2 is a constant? Additionally, you use that logic on both functions so maybe you can abstract this by creating a helper function like isRushThresholdMet(...) - verbosity in this case would help understand the functionality better.
There was a problem hiding this comment.
Completely agree on both. I'll update 2 to be a constant, but Imma come back to the abstraction on a separate PR bc I'm a bit swamped rn lol (and I wanna fix the analytics processing in the backend anyways)
utils/getRushThreshold.ts
Outdated
|
|
||
| export const getRushThreshold = (events: { [key: string]: boolean }) => { | ||
| // Check if at least one mandatory event was attended | ||
| const attendedMandatory = mandatoryEvents.some((event) => events[event]); |
There was a problem hiding this comment.
nit - hasAttendedMandatoryEvent would be a better name
| const attendedMandatory = mandatoryEvents.some((event) => events[event]); | ||
|
|
||
| // Count how many remaining events were attended | ||
| const attendedRemaining = remainingEvents.filter((event) => events[event]).length; |
There was a problem hiding this comment.
nit - numAttendedRemainingEvents? or maybe a better name would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Tests Performed
Screenshots
Additional Comments