Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Family Tree Component #138

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Conversation

jinyoungbang
Copy link
Contributor

@jinyoungbang jinyoungbang commented Aug 3, 2024

What does this PR do?

  • Created family tree UI component
  • NOTE: family tree will only show if user has onboarded + inputted their big on account settings

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update

Tests Performed

Screenshots

Screenshot 2024-08-04 at 1 43 26 PM

Additional Comments

@jinyoungbang jinyoungbang changed the title feat: implement boilerplate structure for family tree feat: Create Family Tree Component Aug 3, 2024
@jinyoungbang jinyoungbang marked this pull request as ready for review August 4, 2024 17:42
@jinyoungbang jinyoungbang requested a review from wderocco8 August 4, 2024 17:43
@jinyoungbang jinyoungbang added the feature New Features label Aug 4, 2024
setFamilyTreeData(data);
setCurrentFamilly(Object.keys(data)[0]);
setCurrentFamillyData(generateFamilyTreeNodesAndEdges(data[Object.keys(data)[0]]));
console.log(data[Object.keys(data)[0]])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console log

};
});

console.log({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log

Copy link
Contributor

@wderocco8 wderocco8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the console logs!

@jinyoungbang jinyoungbang merged commit c117da9 into dev/v1.0 Aug 4, 2024
1 check passed
@jinyoungbang jinyoungbang deleted the feat/family-tree branch August 4, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants