Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/simplify applicant iteration #126

Merged
merged 13 commits into from
May 20, 2024

Conversation

wderocco8
Copy link
Contributor

What does this PR do?

This PR simplifies our usage of API calls when viewing/iterating through applicants. Instead of making additional API calls per each applicant and routing to a new page, we remain on the same page and use state variables to keep track of the index of the selectedApplicant. To do this, we use conditional rendering to handle two cases: 1) view all applicants and 2) view single applicant using ApplicantPage component.

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update

Tests Performed

Tested manually in frontend

Screenshots

Additional Comments

@wderocco8 wderocco8 requested review from jinyoungbang and szou00 May 20, 2024 01:55
@wderocco8 wderocco8 closed this May 20, 2024
@wderocco8 wderocco8 reopened this May 20, 2024
@jinyoungbang jinyoungbang changed the base branch from main to dev/v1.0 May 20, 2024 20:43
Copy link
Contributor

@jinyoungbang jinyoungbang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wderocco8 wderocco8 merged commit 570b738 into dev/v1.0 May 20, 2024
1 check passed
@wderocco8 wderocco8 deleted the refactor/simplify-applicant-iteration branch May 20, 2024 21:01
@jinyoungbang jinyoungbang added the optimization Enhancements label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants