Add docker support and all disks from website #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First off, I wanted to thank you for this project. This is amazing work. I had some nostalgia for my schooldays with the Apple II, and your project gave me pretty much everything in one place. But I wanted to run my own instance of your work, and I've been on a container-kick for awhile and decided to take a stab at running apple2js in a docker container.
The files I created are very simple; I leverage the official node docker image for all of the complicated stuff. Despite everything looking simple, it was a lot of trial-and-error at figuring out the build system (as it seems the latest version of the containers have broken canvas support). This is not a all-in-one container, the website files are checked out on the host and are accessible outside the container. That allows easy modification to the website, like adding disks, without having to rebuild the entire container. It's not convenient, in the fact its not what's expected if this was pulled from docker hub, for example. I'm fairly new to docker (and totally unfamiliar with node), so there might be a better way to do this.
What I don't have in this pull request, though, is modifications to the readme. The build instructions are slightly different:
docker-compose builddocker-compose upto start the web serverThe user will want to modify the docker-compose.yml file with the correct hostname (I could not find a reliable way to disable webpack's hostname checks) and port number as needed.
Finally, I noticed the hosted version on your website had tons of disks that were not in this repo. I thought it might be best to include the full catalog of disks you have on the website in the repo, so its a complete representation of what you have. That also allows for a fully-contained container to be easily created in the future. If you want me to separate these from this PR let me know.
Thanks again!