Various fixes #19
Various fixes #19
Conversation
…al keyboard working too
|
Sorry I didn't notice this when it came in, I get so many github notifications from work that unless I'm assigned or a reviewer I can miss stuff. Looks like some good stuff, checking it out now. |
| keyboard.optionKey(true); | ||
| } else { | ||
| keyboard.commandKey(true); |
There was a problem hiding this comment.
This configuration was selected to allow keyboards with only Alt keys (in this case a Chromebook) to be able to use the apple keys and match the layout. I'm not sure this change matches the correct behavior, since now neither right side option or command activates closed apple.
There was a problem hiding this comment.
The change was so my Mac keyboard would do both open- and closed- apple on option and command keys. Apologies if it breaks other keyboards/OSs.
There was a problem hiding this comment.
The way it currently works is both command/open-apple keys generate open-apple, and left option/alt generates open-apple and right alt generates closed-apple, which I think is the standard Mac keyboard. The problem is probably more of a doc issue. Someday I will write some docs.
There was a problem hiding this comment.
Sorry. My previous comment was wrong. The change was because the left option key on the Mac keyboard was triggering the right (closed-apple) key on the virtual keyboard, and the right option key on the Mac keyboard was triggering the left (open-apple) key on the virtual keyboard. With the change above, the side of the Mac keyboard key matched the virtual keyboard. I also have my Mac option and command keys swapped, so for me it was the command keys in each case. However, it is not a big issue. Let me know if you want any more help with this.
Could not get save/load to local storage to work.
Caps lock key on keyboard works now. It is assumed to be off initially. Press once to change to caps lock on keyboard mode. Press again to change to caps lock off (lowercase). Virtual keyboard will follow caps lock key. Click caps lock on virtual keyboard to change to virtual keyboard mode.
If caps lock on keyboard and virtual keyboard get out of sync (eg if initial assumption is incorrect) typing a character will fix the virtual keyboard display.
Tested on Mac in Firefox.