Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL-MLIR] Empty known_fail list #11

Open
wants to merge 1 commit into
base: sycl-mlir
Choose a base branch
from
Open

[SYCL-MLIR] Empty known_fail list #11

wants to merge 1 commit into from

Conversation

whitneywhtsang
Copy link
Owner

3DConvolution, DRAM, and blocked_transform are not failures.

@whitneywhtsang
Empty known_fail list
1f06a47 
Signed-off-by: Tsang, Whitney <[email protected]>
@whitneywhtsang whitneywhtsang self-assigned this Aug 11, 2023
Naghasan
Naghasan requested changes Aug 14, 2023
View reviewed changes
bin/run-suite
known_fail = {"3DConvolution",
"DRAM",
"blocked_transform"}
known_fail = {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
known_fail = {}
known_fail = set({})

this defaults to map otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naghasan Naghasan Naghasan requested changes

@etiotto etiotto etiotto approved these changes

@victor-eds victor-eds victor-eds approved these changes

@jopperm jopperm Awaiting requested review from jopperm

@sommerlukas sommerlukas Awaiting requested review from sommerlukas

Assignees

@whitneywhtsang whitneywhtsang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whitneywhtsang @Naghasan @victor-eds @etiotto