fix: force engine to be >=18.11.0 as this fixes an issue in proxying …

…a response
wheresrhys · Aug 30, 2024 · dde5e6b · dde5e6b
1 parent abe7203
commit dde5e6b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -8,7 +8,7 @@ references:
 
   node18: &node18
     docker:
-      - image: cimg/node:18.0
+      - image: cimg/node:18.11
   nodelts: &nodelts
     docker:
       - image: cimg/node:lts

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -18,7 +18,7 @@
 	"types": "./dist/esm/index.d.ts",
 	"type": "module",
 	"engines": {
-		"node": ">=18.0.0"
+		"node": ">=18.11.0"
 	},
 	"dependencies": {
 		"@types/glob-to-regexp": "^0.4.4",

diff --git a/packages/core/src/Router.ts b/packages/core/src/Router.ts
@@ -273,8 +273,8 @@ export default class Router {
 				if (typeof response[name] === 'function') {
 					//@ts-expect-error TODO probably make use of generics here
 					return new Proxy(response[name], {
-						apply: (matcherFunction, thisArg, args) => {
-							const result = matcherFunction.apply(response, args);
+						apply: (func, thisArg, args) => {
+							const result = func.apply(response, args);
 							if (result.then) {
 								pendingPromises.push(
 									//@ts-expect-error TODO probably make use of generics here

diff --git a/packages/vitest/package.json b/packages/vitest/package.json
@@ -13,7 +13,7 @@
 	"types": "./types/index.d.ts",
 	"type": "module",
 	"engines": {
-		"node": ">=18.0.0"
+		"node": ">=18.11.0"
 	},
 	"dependencies": {
 		"@fetch-mock/core": "^0.6.3"