Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7 Add support for session expiration #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomisaacson
Copy link

No description provided.

Copy link

@virgilwashere virgilwashere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update README.md?

I've also included support for AWS_SESSION_EXPIRATION my branch, but it's on top of PR #10 and a pending PR

Virgil

@@ -133,16 +139,19 @@ if [[ $? -ne 0 ]]; then
exit 5
fi

if [[ "${SHOW_KEY}" = false && "${SHOW_SECRET}" = false && "${SHOW_SESSION_TOKEN}" = false ]]; then
if [[ "${SHOW_KEY}" = false && "${SHOW_SECRET}" = false && "${SHOW_SESSION_TOKEN}" = false && "${SHOW_EXPIRATION}" = false ]]; then
Copy link

@virgilwashere virgilwashere Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$SHOW_EXPIRATION is probably meant to be $SHOW_SESSION_EXPIRATION

@whereisaaron
Copy link
Owner

@tomisaacson I've been convinced to add this as part of #10. Sorry to pass over your PR, which was first. Would you mind reviewing #10 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants