Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no_std compatibility and remove Coroutine trait #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mrnerdhair
Copy link

I'd like to use this crate in an embedded environment, so I've gone through and replaced all referenced to std with core except for alloc::sync::Arc which is required for the rc and sync engines and std::sync::Mutex which is required for the sync engine alone.

Also, now that nightly's Generator has been updated to take an argument, the custom Coroutine trait isn't required; I've removed it in favor of the base Generator trait.

(These could be split into single-purpose PRs easily if that would be preferable.)

@cameronelliott
Copy link

I'd like to consider this library for a project of mine, and no_std would help for my needs.
It would be cool if Arc and Mutex were not needed, but I think that's probably asking too much.

@mrnerdhair
Copy link
Author

@cameronelliott You don't need Arc or Mutex if you use the genawaiter::stack engine!

@real-felix
Copy link

Hey, I'm interested in this PR, what prevents it to be merged? That would be so cool to have stable generators in my firmware code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants